Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf@28.1 #2777

Conversation

zhangskz
Copy link
Contributor

@zhangskz zhangskz commented Sep 13, 2024

Release: https://github.com/protocolbuffers/protobuf/releases/tag/v28.1

Manual BCR release NOT automated by Publish to BCR due to problem at time of v28.1 release.

@bazel-io
Copy link
Member

Hello @mkruskal-google, @googleberg, modules you maintain (protobuf) have been updated in this PR. Please review the changes.

@zhangskz zhangskz force-pushed the origin/rotocolbuffers/protobuf@v28.1-manual branch from 605b593 to dd94328 Compare September 13, 2024 17:43
@zhangskz zhangskz force-pushed the origin/rotocolbuffers/protobuf@v28.1-manual branch from dd94328 to c707d7f Compare September 13, 2024 17:45
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@Wyverald Wyverald merged commit 083549e into bazelbuild:main Sep 13, 2024
23 checks passed
@honnix
Copy link

honnix commented Oct 4, 2024

Sorry for commenting in this PR. What is the reason there is no any 25 release in BCR?

@zhangskz
Copy link
Contributor Author

zhangskz commented Oct 4, 2024

Hi, in general a github issue would be prefferrable for future inquiries! 25.x predates Protobuf's support in BCR and supports WORKSPACE instead.

@zhangskz zhangskz deleted the origin/rotocolbuffers/protobuf@v28.1-manual branch October 4, 2024 15:15
@honnix
Copy link

honnix commented Oct 4, 2024

Hi, in general a github issue would be prefferrable for future inquiries! 25.x predates Protobuf's support in BCR and supports WORKSPACE instead.

Thank you. I can move the conversation into an issue.

@honnix
Copy link

honnix commented Oct 4, 2024

For the record #2897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants